search

arthurhsliu / distcc

Automatically exported from code.google.com/p/distcc
GNU General Public License v2.0
0 stars 0 forks source link

pump mode fails for e.g. "header,filename,with,a,comma.h" #104

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
distcc 3.2rc1 SVN r755, Ubuntu 11.10, gcc 4.6.1

Linux kernel 3.x includes a header file "drivers/block/smart1,2.h", which 
exposes this pump mode bug.

To demonstrate:

export DISTCC_FALLBACK=0
touch foo1,2.h
echo '#include <foo1,2.h>' > x.c
pump distcc -I. -c x.c

distcc[28982] (dcc_build_somewhere) Warning: remote compilation of 'x.c' 
failed, retrying locally
distcc[28982] (dcc_build_somewhere) Warning: failed to distribute and fallbacks 
are disabled
x.c:1:20: fatal error: foo1,2.h: No such file or directory

Original issue reported on code.google.com by kamal@whence.com on 4 Apr 2012 at 6:53

GoogleCodeExporter commented 9 years ago

Original comment by fergus.h...@gmail.com on 6 Apr 2012 at 11:27

GoogleCodeExporter commented 9 years ago

Original comment by fergus.h...@gmail.com on 6 Apr 2012 at 11:27

GoogleCodeExporter commented 9 years ago 
Kamal, could you please review and/or test the attached patch?

Original comment by fergus.h...@gmail.com on 6 Apr 2012 at 11:33

Attachments:

GoogleCodeExporter commented 9 years ago 
Oh, I forgot to attach the change description.  Here it is:

Fix issue 104 <http://code.google.com/p/distcc/issues/detail?id=104>:
handle header file names containing commas.

Original comment by fergus.h...@gmail.com on 6 Apr 2012 at 11:36

GoogleCodeExporter commented 9 years ago 
Fergus, your patch in Comment 3 works great.  Thanks!

Original comment by kamal@whence.com on 7 Apr 2012 at 2:22

GoogleCodeExporter commented 9 years ago 
Fixed in svn revision 764.

Original comment by fergus.h...@gmail.com on 9 Apr 2012 at 10:37