search

arthurio / fastapi-filter

Filter and order your endpoints
https://fastapi-filter.netlify.app/
MIT License
189 stars 26 forks source link

feat: Support SQLModel #229

Open bartelemi opened 1 year ago

bartelemi commented 1 year ago

I'd like to raise a request for supporting SQLModel library integration.

It should be a relatively straightforward implementation, as SQLModel is based on SQLAlchemy and this lib already has that integration. It would be amazing if the type-safety and generic Select/Query types were supported.

Similar library from the FastAPI ecosystem support it already: https://github.com/uriyyo/fastapi-pagination

I'm happy to raise a pull-request at some point, but I'm submitting this issue to spin up some discussion.

arthurio commented 1 year ago

Just like for tortoise support, I don't personally use SQLModel (yet) so a PR would be appreciated. If I start playing with SQLModel I'll probably do it myself but it's not in my current plans.

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

joshTax commented 4 months ago

No, not stale please

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

joshTax commented 1 month ago

Keepalive

jlantz commented 1 month ago

I'm not sure this is still an issue. I just got done implementing my first filter with fastapi-filter using SQLModel. I just pointed it at my main SQLModel, the one with table=True, and it worked fine.

I'd be curious to hear if others have hit any issues trying this?