search

arthurnn / memcached

A Ruby interface to the libmemcached C client
Academic Free License v3.0
432 stars 125 forks source link

Multiple compile errors where C++ code/comments used #122

Closed oddraisin closed 11 years ago

oddraisin commented 11 years ago

When trying to install memcached-1.5.0 and 1.5.1 via gem on FreeBSD 9.1-RELEASE, I received many errors where C++ conventions / code were used in C files. cc would fail to compile as a result. Examples: declaring loop variables within the loop (for (unsigned int x=0;...)), commas on the last items in an enum, and C++ style // comments. Affected files were:

memcached_exist.h memcached/protocol_binary.h libmemcached/memcached_do.c libmemcached/memcached_io.c libmemcached/memcached_flush_buffers.c

I can provide a diff that I used to get it to compile properly on my system if it would help.

evan commented 11 years ago

Sure, would appreciate a pull request.