Memcached rails updates

arthurnn / memcached

A Ruby interface to the libmemcached C client

Academic Free License v3.0

432 stars 125 forks source link

Memcached rails updates #133

Closed joe1chen closed 11 years ago

joe1chen commented 11 years ago

CHANGELOG: -Add travis configuration file (tests rubies 1.8.7, 1.9, 2.0, and rbx 1.9 mode). -Fixes for unit tests breaking under Ruby 1.8.7. -Updated gemspec to add check for signing key so that we can also build unsigned gem. -Add travis build status image to README.rdoc. -Fix Memcached::Rails write to allow nil options to be passed. -Fix Memcached::Rails fetch's default options parameter to be nil.

joe1chen commented 11 years ago

@evan Is this sufficient? I've merged all changes into this pull request. Did you want an actual file called CHANGELOG with my above comments to be added?

evan commented 11 years ago

Yeah, add a new minor version and commentary to the CHANGELOG file.

joe1chen commented 11 years ago

@evan CHANGELOG has been updated. It looks like the version is bumped when I add a new version to the CHANGELOG.

evan commented 11 years ago

Hey, your change to the gemspec doesn't work since Echoe rebuilds it and overwrites the change. You will have to add something to Echoe or the gem's own Rakefile to generate the correct gemspec.