set should retry on client error

erks commented 10 years ago

Memcached::ClientError retry code in Memcached::set doesn't do as intended. @arthurnn @evan

Also:

removed a unicode char from memcached.gemspec
added if $0 =~ /gem\z/to the end of the s.signing_key line to allow bundle install to succeed (hence happy travis-ci)
reenabled and fixed the relevant unit test (test_set_retry_on_client_error)

dylanahsmith commented 3 years ago

Memcached::ClientError retry code in Memcached::set doesn't do as intended.

It is really weird that the code was even trying to retry for a client error, since those shouldn't be transient errors.

Did you actually encounter this error from running the code as opposed to just reading the code? What was the client error that you expected to be retried?

From commit a5042221023f53f270f6a2e4b01319b4ece2e3c9 the previous version of this retry code had a # FIXME Memcached 1.2.8 occasionally rejects valid sets comment, so it looks like it was just working around a server bug. So it seems like the code should be removed consider it deceptively does nothing and we should instead focus on the source of the bug.

dylanahsmith commented 3 years ago

Fixed by #198

arthurnn / memcached

set should retry on client error #155