search

arthurnn / memcached

A Ruby interface to the libmemcached C client
Academic Free License v3.0
432 stars 125 forks source link

Fix truncation of bytes/bytes_read/bytes_written stats #156

Open aroben opened 9 years ago

aroben commented 9 years ago

These stats are stored in a uint64_t but we were truncating them to 32 bits.

arthurnn commented 8 years ago

hey @aroben , thanks for the PR. We just embed the memcached C client in the gem. So, is this changed in the C client? If so, I can bump it here. Otherwise we might need to send a patch there instead.

aroben commented 8 years ago

So, is this changed in the C client?

Yeah, as mentioned above, newer versions of the C client have already fixed this bug.

arthurnn commented 8 years ago

@aroben , I am looking into update the client here, as it is SUPER old.. but before I have all that done, I need to get CI back to green, and after I have that I will merge this for us.. thanks a lot

dylanahsmith commented 3 years ago

The embedded libmemcached has been upgraded to 1.0.18 on master now, which is the newest release, so I think this can be closed now.