As pointed out in #155, the !tries condition was never true, so the if statement that uses it was just dead code. As I replied in that PR
From commit a5042221023f53f270f6a2e4b01319b4ece2e3c9 the previous version of this retry code had a # FIXME Memcached 1.2.8 occasionally rejects valid sets comment, so it looks like it was just working around a server bug.
So instead of "fixing" that if statement, this PR proposes to instead just remove it along with the associated disabled test (i.e. the method doesn't start with test_).
dylanahsmith
commented
3 years ago
Closes #155. cc @erks
As pointed out in #155, the
!triescondition was never true, so theifstatement that uses it was just dead code. As I replied in that PRSo instead of "fixing" that
ifstatement, this PR proposes to instead just remove it along with the associated disabled test (i.e. the method doesn't start withtest_).