"swig_runtime_data" is not a valid constant name in Ruby

arthurnn / memcached

A Ruby interface to the libmemcached C client

Academic Free License v3.0

432 stars 127 forks source link

"swig_runtime_data" is not a valid constant name in Ruby #37

Closed brixen closed 13 years ago

brixen commented 13 years ago

In Ruby, constant names begin with an uppercase character.

https://github.com/fauna/memcached/blob/master/ext/rlibmemcached_wrap.c#L1737

evan commented 13 years ago

Does this cause any actual problem? Note that it's in the autogenerated SWIG code, so potentially an issue in SWIG.

brixen commented 13 years ago

Unfortunately, yes.

https://github.com/evanphx/rubinius/issues#issue/692

Evan (the other Evan :) pointed out this is SWIG. I looked at their sourceforge project and it's got 173 open bugs, so getting it fixed might not be easy.

I'm not sure what the best approach is. But this is really bad on SWIG's part.

rocky commented 13 years ago

I've opened a SWIG issue. See https://sourceforge.net/tracker/?func=detail&aid=3187444&group_id=1645&atid=101645

evan commented 13 years ago

Added a dumb fix to 1.0.7.

rocky commented 13 years ago

Great! Will try to get those changes back into Swig.