search

arthurnn / memcached

A Ruby interface to the libmemcached C client
Academic Free License v3.0
432 stars 125 forks source link

Sean Lynch's fixes for northscale #62

Closed avsej closed 12 years ago

avsej commented 13 years ago

Hi guys.

I found a couple of fixes from @seanlynch and rebased them on latest code. They mostly touch rails interface to library, but I think they could be useful.

Note, that this patchset introduces API change: memcached operations won't raise exceptions when something goes wrong -- just eat them and return false like if Memcached::NotFound raised.

Thanks.

ingenthr commented 13 years ago

The API change would break compatibility with existing code, I'm sure. Is there an easy way to make this behavior configurable?

avsej commented 13 years ago

Yes I think. It will look like this setting for return codes https://github.com/fauna/memcached/blob/master/lib/memcached/rails.rb#L92

evan commented 13 years ago

What problem are you trying to solve with these changes? Is there some other server that's incompatible?