search

arthurnn / memcached

A Ruby interface to the libmemcached C client
Academic Free License v3.0
432 stars 125 forks source link

Handle unexpected return codes #76

Closed gcampbell closed 12 years ago

gcampbell commented 12 years ago

Previously, these would throw a TypeError because of an attempt to raise nil, which was a little confusing. This implementation should make them easier to track.

evan commented 12 years ago

Looks good to me. Can you update the CHANGELOG file?

gcampbell commented 12 years ago

Sorry - did you want me to add a new version to the changelog or add my change to 1.3.6?

evan commented 12 years ago

Add a new minor version if 136 is released, which I think it is.

Evan

On Wednesday, December 7, 2011, Greg Campbell < reply@reply.github.com> wrote:

Sorry - did you want me to add a new version to the changelog or add my change to 1.3.6?

Reply to this email directly or view it on GitHub: https://github.com/evan/memcached/pull/76#issuecomment-3055139

gcampbell commented 12 years ago

I pushed a commit that bumps the version to 1.3.7 in the CHANGELOG, but I later noticed that 1.3.5 appears to be the newest version on http://rubygems.org/gems/memcached, so I don't think 1.3.6 was ever formally released. I can revise things to add my change to 1.3.6 if you like.

evan commented 12 years ago

Yeah, if there were queued changes we should bundle with that and then release. Sorry for not being clear.