search

arthurnn / memcached

A Ruby interface to the libmemcached C client
Academic Free License v3.0
432 stars 125 forks source link

Fixed the servers method in the rails wrapper #86

Closed tomhughes closed 12 years ago

tomhughes commented 12 years ago

I'm afraid you broke the servers method slightly ;-)

Calling server_structs a second time returns a fresh array which hasn't had the alive? methods added, so we need to return the original, modified, array. I've also add a test to make sure the alive? method is working.

evan commented 12 years ago

Crap! I thought there was test coverage.

tomhughes commented 12 years ago

Well there was, but it had accidentally wound up in compare_servers, which you rewrote, losing the test in the process ;-)

evan commented 12 years ago

:-(

New release coming.

evan commented 12 years ago

Does 1.4.1 work for you?

tomhughes commented 12 years ago

Yes, that looks better.