search

arthurnn / memcached

A Ruby interface to the libmemcached C client
Academic Free License v3.0
432 stars 125 forks source link

add gemfile #90

Closed grosser closed 12 years ago

grosser commented 12 years ago

so I can just bundle and do not have to figure out what dependencies I need

evan commented 12 years ago

Actually, memcached.gem has no runtime dependencies. Everything you list is a dev dependency.

grosser commented 12 years ago

sorry, what I meant is that I do not have to figure out the dependencies when I want to run the tests

grosser commented 12 years ago

took me 5 tries to get the tests to run / might as well have failed because tests depend on version x.y.z of one of the dependencies

evan commented 12 years ago

Is there a way to do that with rubygems? memcached.gem is bundler-agnostic right now.

grosser commented 12 years ago

it does not change the gem or make it bundler agnostic in any way, just makes development easier / safe of random version changes

evan commented 12 years ago

I listed dev dependencies the rubygems way. gem install --development appears to not work, but that's not my problem I guess. At least they are specified.

grosser commented 12 years ago

With the development dependencies in place the Gemfile could be

source :rubygems
gemspec

doesn't get any simpler then that + you get a know set of exact versions that the tests works with :)

evan commented 12 years ago

Sounds ok. Can you update the pull request with the lockfile or whatever else is necessary.

grosser commented 12 years ago

Done! :)

grosser commented 12 years ago

hmmm its on my branch but this did not get updated, can you reopen it, maybe then it works...