search

arthurpsmith / wikidata-tools

My collection of tools for interacting with the wikidata database
14 stars 15 forks source link

Don’t redirect without a valid link string #29

Closed lucaswerkmeister closed 2 years ago

lucaswerkmeister commented 2 years ago

Fixes #28.

Note: I haven’t tested this at all :)

arthurpsmith commented 2 years ago

This is definitely not the way to fix this, to the degree this can be fixed and still function here. See for example property 213 - all it does is reformat the ID slightly. So you could do exactly the same thing adding p=213 to the passed-in parameters and your fix would be ignored. I'm trying to understand exactly what the problem is that's trying to be addressed by this.

lucaswerkmeister commented 2 years ago

This is definitely not the way to fix this, to the degree this can be fixed and still function here. See for example property 213 - all it does is reformat the ID slightly. So you could do exactly the same thing adding p=213 to the passed-in parameters and your fix would be ignored.

Alright, then please fix that. It’s your tool, clearly you know it better than I do.

I'm trying to understand exactly what the problem is that's trying to be addressed by this.

I replied in #28.