vanflad
commented
7 years ago Hey,
I think Mark of Homework 2 is where we could have commented but it is confusing since it can be considered homework 7 or homework 2, depending on your perspective. Anyways, I agree that this assignment was really well done and you showed great understanding of make and many other complex R tasks such as data manipulation and graphs. I appreciated how organized and detailed everything was and the colourful graphs were really impressive but I also have a couple comments for further improvement! If you use guide=FALSE for your fourth figure, you can drop the additional legend that was created when you increased the point size. Also, I'm wondering why you loaded so many libraries at the beginning of the markdown? There were multiple libraries for gapminder, tidyverse, ggplot, stringr, tidyr, some of these are already included within tidyverse, some with suppress messages and some without. One last thing, the tables I took a quick look at and there are some typos and repeats of tables where there shouldn't be. I listed them out and you have asiagood, asiagood once again (just a typo because you did calculate asiabad), europegood, europebad, americagood, (there is no americabad), africabad, africagood, asiabad and asiagood. So Asia is repeated, maybe supposed to be oceaniabad and oceaniagood or did you purposefully leave it out of the analysis because of the low number of countries since you also don't have a plot for oceania? Anyways, you still did a great detailed job on the assignment!! 👍
Cheers,
Vanessa
ksedivyhaley
Hi Arthur, I couldn't find the issue where I would normally comment so I made my own here.
I liked your homework makefile. In addition to the makefile set up you did a lot of different analysis and plotting that involved many of the skills we have covered earlier in the course including reading and writing to file, reordering data, and ggplot. I noticed how you used the broom package, which I wasn't familiar with. It seems like a good way to do some statistical analysis and I will try making use of it in the future!
I have no major critiques as it looks like you put a lot of effort into this homework. One minor suggestion involves your use of colour for minimum life expectancy. It seems redundant to use colour for a variable whose magnitude is already indicated by the y-axis in this case. Perhaps a different variable such as population could be assigned to another aesthetic, such as size, that would help to provide your audience with more information rather than the same information.
Overall this was a great assignment and I hope you enjoy the rest of the course!
Seth