artic-network / artic-ncov2019

ARTIC nanopore protocol for nCoV2019 novel coronavirus
Creative Commons Attribution 4.0 International
168 stars 166 forks source link

Nanopolish version doesn't exist on MacOS #22

Closed jameshadfield closed 4 years ago

jameshadfield commented 4 years ago

We currently require nanopolish=0.12.5 but on MacOS the most recently available version is 0.11.3.

Unsure what the best solution is:

will-rowe commented 4 years ago

I was running into this whilst testing the fieldbioinformatics pipeline on OSX

The pipeline requires nanopolish features that aren't available in 0.11.3 - so your first option is the best solution currently.

I had been ignoring this and just installing nanopolish from source whilst testing, but we are going to need a fix. Any idea what the issue is with getting the latest nanopolish for mac into conda? I'm guessing there is one! I can have a stab at it next week maybe

nickloman commented 4 years ago

@jts looked at this a bit, not sure how far he got?

jts commented 4 years ago

Not very far unfortunately - the conda maintainers changed the nanopolish build script for 0.12.0 so this will take a bit of work. I can help but won't have a ton of time today

jts commented 4 years ago

Does anyone know what version of MacOS conda builds against? I'm on 10.15.3 and hitting this header error with the conda version of gcc (4.8):

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90835

nickloman commented 4 years ago

Is it 10.9?

jts commented 4 years ago

for those that want to see me struggle, I'm trying to fix this here: https://github.com/bioconda/bioconda-recipes/pull/21282

jmarshall commented 4 years ago

This will be fixed by bioconda/bioconda-recipes#21330.

jts commented 4 years ago

This is great @jmarshall, thanks so much for fixing this.

will-rowe commented 4 years ago

Thanks @jmarshall - that's brilliant! And thank you too @jts

nickloman commented 4 years ago

I believe this is now fixed.