artic-network / fieldbioinformatics

The ARTIC field bioinformatics pipeline
MIT License
110 stars 69 forks source link

Clarify what's meant by 'Suppress variant' #129

Open smsaladi opened 9 months ago

smsaladi commented 9 months ago

I understand that when one variant that passes and another that fails at a given site, a message is printed:

https://github.com/artic-network/fieldbioinformatics/blob/8eb6a0c619030b137f8c97545aa1b763b94446db/artic/vcf_filter.py#L108

It might be helpful to have a minor change in wording (even "Suppress" -> "Suppressed") to clarify that a passing variant won't be written to the consensus sequence. I'm not sure if a few more characters would break any downstream pipelines, so it's just shared as a suggestion.