search

artic-network / fieldbioinformatics

The ARTIC field bioinformatics pipeline
MIT License
112 stars 68 forks source link

fix for right primer merge #47

Closed will-rowe closed 4 years ago

will-rowe commented 4 years ago

as pointed out by Shirlee Wohl - the merge_sites function was producing the intersection, not union, between alts and canonicals for right primers.

nickloman commented 4 years ago

Is there a unit test? Could we ask Shirlee for test data?

will-rowe commented 4 years ago

We could use ARTIC V3?

We already check that alt's are merged to canonical primers in the unit test: https://github.com/artic-network/fieldbioinformatics/blob/master/artic/vcftagprimersites_unit_test.py

We could add in a further check that makes sure the union for start/end of the canonical is correct?

nickloman commented 4 years ago

Thanks.