artic-network / fieldbioinformatics

The ARTIC field bioinformatics pipeline
MIT License
110 stars 68 forks source link

align_trim strand consideration #72

Closed chienchi closed 3 years ago

chienchi commented 3 years ago

When doing align_trim, I noticed a read could be soft-clipped by both forward and reverse primers.

Sorry, I am not familiar with sequencing protocol in detailed, but should the align_trim take the strand into account while doing the trimming, so forward primers are trimmed only from forward strand and reverse primers are trimmed from reverse strand?

before line 231: if not segment.is_reverse: before line 243: if segment.is_reverse:

nickloman commented 3 years ago

Hi

Both the primers will be present at each end of the read, regardless of strand, so no need to account for this specifically.

chienchi commented 3 years ago

Got it. Thank you.