search

artic-network / rampart

Read Assignment, Mapping, and Phylogenetic Analysis in Real Time
GNU General Public License v3.0
79 stars 33 forks source link

Add --cores argument to snakemake calls #72

Closed jameshadfield closed 4 years ago

jameshadfield commented 4 years ago

Snakemake >=5.11 made this argument mandatory. Additionally, we should check the snakemake version on startup to ensure it's recent enough to use the features we use in it.

sagrudd commented 4 years ago

Is there a timeline for this update? Could this be included for the 1.2.0 release?

jameshadfield commented 4 years ago

Should be easy. I'll add this tomorrow and release 1.2.0rc2 for testing

jameshadfield commented 4 years ago

Available in 1.2.0rc3 -- if you could test this that'd be wonderful!

conda install artic-network/label/test::rampart==1.2.0rc3

I plan to release 1.2.0 in ~24 hours if there are no regressions identified

sagrudd commented 4 years ago

This all looks great and I have good builds of a container on AMD64 and ARM64v8 using general versions of snakemake from pip = happy camper; thanks!

jameshadfield commented 4 years ago

This is part of the v1.2.0 conda release 🎉