search

artichoke / strftime-ruby

⏳ Ruby `Time#strftime` parser and formatter
https://crates.io/crates/strftime-ruby
MIT License
12 stars 0 forks source link

Use `aws s3 sync --delete` when uploading coverage results to S3 #38

Closed lopopolo closed 2 years ago

lopopolo commented 2 years ago

This handles the case where files are moved in the source tree.

See:

Speed up the build by downoading pre-compiled grcov binaries from https://github.com/mozilla/grcov/releases.

lopopolo commented 2 years ago

@x-hgg-x this is ready to review.

The corresponding AWS changes are at https://github.com/artichoke/project-infrastructure/pull/335.

I verified that https://codecov.artichokeruby.org/strftime-ruby/src/test.rs.html no longer exists.

x-hgg-x commented 2 years ago

This looks good to me.

Since you have created and reverted temporary commits, we should squash all the commits to discard history.

lopopolo commented 2 years ago

Sounds good, I'll squash next time.