search

articodeltd / angular-cesium

JavaScript library for creating map based web apps using Cesium and Angular
https://github.com/articodeltd/angular-cesium/settings/pages
MIT License
178 stars 93 forks source link

Angular2Parse dependency prevents upgrade to angular 10/11 #364

Open renegadeCode opened 3 years ago

renegadeCode commented 3 years ago

Not sure what can be done. I tried to do a PR fixing the issue angular2parse has with newer versions of Angular.

Intended outcome: Upgrade angular to 10/11.

Actual outcome: Failed upgrade because of angular-cesium's dependency on angular2parse.

How to reproduce the issue: Use ng to upgrade angular to angular 11.

Version

Crocsx commented 3 years ago

I forced the upgrade on angular 11 (didn't really checked this specific issue) and I am running with it without a problem. It will potentially break in the future, but for a version bump to latest angular it is ok for the moment.

aznguy commented 3 years ago

Cool, You mean this fork? : https://github.com/Crocsx/angular-cesium are there any plans for merging this into the original code base?

Or @Crocsx Maybe you can create a PR

Crocsx commented 3 years ago

@aznguy No, this original repo works on angular 11 without issue. (I mean at least for what I use it) Only need to add the 

"allowedCommonJsDependencies": ["geodesy", "util"],

to remove the compilation warnings.

I think you can try to force the update if you need.

My fork was a tentative to make this library works with the Cesium provided types (without having Cesium attached to the window object) and remove obsolete packages, but I kind of give up for now. ^^