articodeltd / angular-cesium

JavaScript library for creating map based web apps using Cesium and Angular
https://github.com/articodeltd/angular-cesium/settings/pages
MIT License
178 stars 93 forks source link

Upgrading to Angular 13, Cesium 1.101.0 #442

Closed arye97 closed 1 year ago

arye97 commented 1 year ago

Features

Running locally, all things build as expected. Demo runs as before.

As angular 13 now builds with partial ivy compared to ngcc before, the circular dependency between AcMapComponent and CesiumService was no longer allowed, so this was changed to be any type. However it still is the AcMapComponent under the hood, so works as before.

Had to make some edits to the eslint rules as they're more strict now in ESLint and specifically the angular 13 rules. They required all components to begin with ac- in their selector, I chose to not do this as it would be a breaking change for people upgrading.

Checklist:

arye97 commented 1 year ago

@shayb-datumate @aleks-datumate I'm unsure who's able to merge in this PR but I see you two completed the last PR two weeks ago #439, can you please check this one?

@eitanfr @davidyaha

arye97 commented 1 year ago

Closing as no response