search

articodeltd / angular-cesium

JavaScript library for creating map based web apps using Cesium and Angular
https://github.com/articodeltd/angular-cesium/settings/pages
MIT License
178 stars 93 forks source link

Offline option of map layer provider does not work. #72

Closed gotenxds closed 7 years ago

gotenxds commented 7 years ago

in this file map-layer-provider.component.ts

The switch case for : `

    switch (this.provider) {
        case MapLayerProviderOptions.WebMapService:
            this.layerProvider = AcMapLayerProviderComponent.createWebMapServiceProvider(this.options);
            break;
        case MapLayerProviderOptions.WebMapTileService:
            this.layerProvider = AcMapLayerProviderComponent.createWebMapTileServiceProvider(this.options);
            break;
        case MapLayerProviderOptions.ArcGisMapServer:
            this.layerProvider = AcMapLayerProviderComponent.createArcGisMapServerProvider(this.options);
            break;
        case MapLayerProviderOptions.OFFLINE:
            break; <-- remove this
        default:
            this.layerProvider = AcMapLayerProviderComponent.createOfflineMapProvider();
            break;
    }

`

Has a redundant break it skips over and does nothing, remove it or remove the option completely so it goes to default.

eitanfr commented 7 years ago

👍 nice that you noticed. already fixed in #70, will merge it soon

eitanfr commented 7 years ago

resolved #70

sameer1319 commented 2 years ago

Hi I have a quick question I am new to Cesium how would I use offline maps?