artiebits / svelte-seo

Optimize your website for search engines and social media with meta tags, Open Graph, and JSON-LD.
https://artiebits.com
MIT License
429 stars 24 forks source link

Suggesting a complete rewrite of this library #44

Closed lubiah closed 1 year ago

lubiah commented 1 year ago

Hi @artiebits, I want to suggest that we rewrite this library entirely. The reason for this is the manner in which this library was initially created. Currently, there are two popular Svelte libraries for SEO: this library and Svelte Meta Tags. Though this library has more stars, forks and watches than the library, it has more options than this library. The use of if statements make it really painful to create additional tags since you will be writing a lot of ifs.

Also, I suggest we move from using rollup to vite. SvelteKit nows makes it very easy to package a library and we are still using the old-school method.

For the testing, we need to move from cypress to vitest. That's because Vitest is very fast and Cypress takes a very long time to install.

If you would allow, we can outline the goals for the rewrite and I will task myself to coding it.

Thank you

artiebits commented 1 year ago

hi @kudadam,

I like your initiative. Feel free to work on these improvements and open PRs, I would appreciate it a lot. My only suggestion is to keep PRs as small as possible (meaning don't do everything in one PR). Let know if you have questions.

lubiah commented 1 year ago

@artiebits , What am suggesting is that you allow me to start the new rewrite on another branch then I work on it gradually till it's ready. Here are some of the changes I wanted to make:

artiebits commented 1 year ago

sure, go ahead 👍 and thanks for your contribution!

lubiah commented 1 year ago

Okay, I will start right away