Tag "alt" on UML is mandatory on local store

artifacthealth / typedoc-plantuml

Plugin for TypeDoc that generates images for PlantUML diagrams embedded in comments.

Apache License 2.0

15 stars 6 forks source link

Closed Chklang closed 8 years ago

Chklang commented 8 years ago

After some hours of problems i've found this bug.

If your comment is :

     * <uml>
     *     Bob->Alice : hello
     * </uml>

So the generation by typedoc will done : <img src="http://www.plantuml.com/plantuml/png/UDhZKW02f_maNJl7dCpaL0KhXOpKd9nyBW17hWP_" alt="">

So the regexp : encodedUmlExpression = /<img src="http:\/\/www.plantuml.com\/plantuml\/(?:img|png|svg)\/([^"]*)"(?: alt="(.+)")?>/g,

don't work because "alt" attribut is empty.

meirgottlieb commented 8 years ago

Nice catch. I just pushed a new version to NPM that fixes this bug.

Chklang commented 8 years ago

Great!

Very very reactive!