artifacthealth / typedoc-plantuml

Plugin for TypeDoc that generates images for PlantUML diagrams embedded in comments.
Apache License 2.0
15 stars 6 forks source link

I'd like to discuss some improvements I made #6

Open 0815fox opened 8 years ago

0815fox commented 8 years ago

Hi Gottlieb! First thank you for this nice idea and the very nice work. I did not even know about PlantUML.

It's an honor to write the first ticket here. I forked your project and did some improvements, which I'd like to discuss about. Also I would like to know, whether you were interested to work together on this.

What I did so far:

--umlClassicHierarchy               none,before,behind
 --umlComplete                       none,simple,detail
 --umlFormat                         png,svg
 --umlHierarchy                      none,simple,detail,alldetail
 --umlHierarchyDepthDown             [-1,∞)
 --umlHierarchyDepthUp               [-1,∞)
 --umlLocation                       /^local|remote|(?:https?:\/\/)?[^ "]*$/
 --umlSeperateClassDetailView        true|false
 --umlShowSpot                       true|false
 --umlTag                            true|false
 --umlThreads                        [1,∞)
 --umlVisibilityIcons                none,ascii,graphic

screenshot1

(Sorry, working on a business project - I am not allowed to share the fancier class diagrams, but it works - even multiple implements/extends-paths...)

Some other things to mention:

What still is open, before I submit a pull request:

Thank you for your feedback :-) Greetings, Michael

meirgottlieb commented 8 years ago

Wow. Great stuff! I'm fine with switching to TypeScript. That would be great. If you do that, take a look at the latest plugins in TypeDoc. He's now doing them using a class with decorators instead of the function for the plugin like I'm doing.

0815fox commented 8 years ago

Oh thats interesting... Thank you. Have you any links about that topic (did not yet find decorators in his documentation)? Is there a thread in which you read that? Where can I find a sample plugin?

meirgottlieb commented 8 years ago

Here is an example of one of the newer plugins. You see it uses a decorator to define the Component. It's also using a base class that helps wire up the events it's listening too. If you look at the converter source, you can see options being defines with a decorator as well.

slollar commented 7 years ago

I was wondering if 0815fox's code was ever merged or created elsewhere. I would really like to have the automatically generated from typescript portion! Thanks!

meirgottlieb commented 7 years ago

No, a pull requested was never submitted.

slollar commented 7 years ago

Dang...thanks for the quick response!

meirgottlieb commented 7 years ago

His branch is public so maybe you can just use that: https://github.com/0815fox/typedoc-plantuml

slollar commented 7 years ago

Thanks - I found this too https://www.npmjs.com/package/typedoc-plantuml-extended which looks like the same thing.

0815fox commented 7 years ago

Of course you can use it. I stopped working on it because other things became more important in our small business (3 people working on our project). I didn't submit a pull request because of the mentioned change in the way plugins are loaded.

krisztianb commented 4 years ago

I just wanted to let you know that the package typedoc-plantuml-extended posted by @slollar, which is the extension created by @0815fox is working with the latest 0.15.0 typedoc. And so does the original typedoc-plantuml package by @meirgottlieb.