search

artilleryio / artillery-core

artillery-core - deprecated
Mozilla Public License 2.0
29 stars 104 forks source link

Feature/socketio acknowledgements #181

Closed Demostrike closed 7 years ago

Demostrike commented 7 years ago

This allows you to test emit acknowledgements in artillery.io as per the socket.io spec.

Reuses code for comparisons/matches where possible.

Demostrike commented 7 years ago

Anyone care to comment on this? Is it appropriate?

hassy commented 7 years ago

Apologies @Demostrike, haven't had the time to review new PRs yet. Thanks, and I'll try to get it reviewed soon.

Demostrike commented 7 years ago

No worries @hassy, just want to make sure on if it can be included as a contribution. Would love to see it or a similar option or acknowledgments in the release for use.

plumpNation commented 7 years ago

Would love to see this! Was just about to have a crack myself.

plumpNation commented 7 years ago

Oh and @Demostrike, I have a comment, this is brilliant. Thankyou. I've been using it for the last month.

hassy commented 7 years ago

Thanks @Demostrike! (& @plumpNation as well for extensive testing :)

There will be an Artillery release later this week which will include this change.