search

artilleryio / artillery-core

artillery-core - deprecated
Mozilla Public License 2.0
29 stars 104 forks source link

fix(socketio) Fix cookies jar not instantiated in socketio context #182

Closed InvictusMB closed 7 years ago

InvictusMB commented 7 years ago

Closes shoreditch-ops/artillery#310

It's a bit too difficult to provide test for this as there is apparently no test suite that validates http engine capabilities for socketio engine at all. And setting that up would be too big of a change for the scope of this PR as it needs either reorganizing tests or doing a lot of copy-pasting in both test scenarios and test infra code.

InvictusMB commented 7 years ago

@hassy Could you provide any feedback on this PR? I would really like to get rid of the hacks in my artillery scripts that I have to maintain because of this bug.

hassy commented 7 years ago

Apologies for taking a while. The fix looks fine to me, new tests can be added separately. Would you mind amending the commit message: there should be a blank line between the summary and the body, there's also a colon missing after fix(socketio).

InvictusMB commented 7 years ago

Updated the commit message. Also added integration test for cookies jar in socketio engine

hassy commented 7 years ago

Awesome, thanks @InvictusMB!