search

artilleryio / artillery-core

artillery-core - deprecated
Mozilla Public License 2.0
29 stars 104 forks source link

Match/Capture all callback data in Socket.IO Ack #206

Closed ragecryx closed 7 years ago

ragecryx commented 7 years ago

Resolves #205

hassy commented 7 years ago

Thanks @ragecryx, will need to review

hassy commented 7 years ago

Apologies for taking so long on this one. Looks fine to me at a quick glance - the only thing I'm unsure about is if the original behavior remains unchanged (this PR: https://github.com/shoreditch-ops/artillery-core/pull/181), since we're now passing an array where a single value used to be expected (https://github.com/shoreditch-ops/artillery-core/pull/206/files#diff-4c8bbeda468bf6bfdd048bd21ee2d037R199).

If you have the time to add a test case for that (the original PR didn't have one), that'd be great. Otherwise I'll try to do it in the next few days.

ragecryx commented 7 years ago

Oh, I didn't give much thought about supporting existing behavior since "acknowledge" wasn't referenced in the docs or the examples and there were missing tests for it too. But I'll into this. Do you want me to add some documentation or examples in the docs repo too?