phases is not adjusted when the arrivalRate is zero

[ykokw]

artillery version: 1.6.0-2

When I run load test with following phase config, (I set arrivalRate to 0)

  phases:
    - duration: 30
      arrivalRate: 0
      rampTo: 30

I've got a warning message.

Unknown phase spec definition, skipping.
{"duration":30,"arrivalRate":0,"rampTo":30}
This should not happen

In the divideWork method of the lib/dist.js, all conditional statement looks return false if arrivalRate is 0. It should confirm that phase is included each parameters (e.g. phase.hasOwnProperty("arrivalRate"))

https://github.com/shoreditch-ops/artillery/blob/da7e4aa9397c5d3c27dc406be066069a49aa8787/lib/dist.js#L25

    if (phase.arrivalRate && phase.rampTo) { //if arrivalRate is 0, it become false
      let rates = distribute(phase.arrivalRate, numWorkers);
      let ramps = distribute(phase.rampTo, numWorkers);
      L.each(rates, function(Lr, i) {
        newPhases[i][phaseSpecIndex].arrivalRate = rates[i];
        newPhases[i][phaseSpecIndex].rampTo = ramps[i];
      });
      return;
    }

It looks uses original phases config (not adjusted)

[hassy]

Thanks @ykokw

[hiepluong2205]

Same issue. Thanks ykokw