artipie / benchmarks

Benchmarks for Artipie repositories
MIT License
6 stars 9 forks source link

feat: plot charts for benchmarks results #39

Closed genryxy closed 2 years ago

genryxy commented 2 years ago

Part of artipie/artipie#431 Added script for plotting charts for benchmarks results

genryxy commented 2 years ago

Example of charts are below 1 2

genryxy commented 2 years ago

@g4s8 I thought to add one more step to this script. Something like this:

          cp -avr out/${{ env.REPO }}/* $GITHUB_WORKSPACE/benchmarks/results/${{ env.TAG }}
          cd ../..
      - name: Add results to README
        run: |
          # probably here also `pip install matplotlib` 
          python benchmarks/scripts/writeresults.py ${{ env.TAG }}
          python benchmarks/scripts/charts.py number-charts-to-plot
          rm -rf tmp-bench
g4s8 commented 2 years ago

@g4s8 I thought to add one more step to this script. Something like this:

          cp -avr out/${{ env.REPO }}/* $GITHUB_WORKSPACE/benchmarks/results/${{ env.TAG }}
          cd ../..
      - name: Add results to README
        run: |
          # probably here also `pip install matplotlib` 
          python benchmarks/scripts/writeresults.py ${{ env.TAG }}
          python benchmarks/scripts/charts.py number-charts-to-plot
          rm -rf tmp-bench

@genryxy but then we need to add it to each adapter and it'll be not consistent with other steps of benchmark. Using Makefile we can hide this boilerplate code and use common dependencies for that, e.g. make draw-graph will depend on benchmarks running and can run it automatically and copy all results to correct directories. So we can call only one command from actions workflow file to perform all steps in one command.

genryxy commented 2 years ago

@g4s8 could you please check this one

g4s8 commented 2 years ago

@g4s8 could you please check this one

@genryxy can you please answer or fix my last comment here https://github.com/artipie/benchmarks/pull/39#issuecomment-972582577

genryxy commented 2 years ago

@g4s8 I add this step to make in this PR. One for writing results to the file and another step for plotting graphics