artisan-roaster-scope / artisan

artisan: visual scope for coffee roasters
https://artisan-scope.org
GNU General Public License v3.0
941 stars 254 forks source link

Artisan 2.8.0 problem with Probat P12/2 #1002

Closed grebdnul closed 1 year ago

grebdnul commented 2 years ago

Describe the bug Modbus TCP connection appears to stop working after a few gas or air changes has been sent to roaster. Communication works fine with Artisan version 2.6.0.

To Reproduce Steps to reproduce the behavior:

Select "Propat P-series 7" as machine and add air slider. Start and send a few airspeed-changes or gas changes.

Expected behavior Expected behavior is that the roaster reacts to every gas and air-change.

Setup (please complete the following information):

Additional context Problem started on MacOS 12 with direct TP cable to roaster. Have downgraded to MacOS 11.7.1 and also added router with calble connected fixed ip-adresses for computer and roaster. Same problem on both MacOS 12 and 11 with Artisan 2.8.0. Uninstalled and installed Artisan 2.6.0 and everything works fine. Could it have something to do with new TCP-settings in 2.8.0?

artisan-settings_P12_nyast.aset.zip

(Thank you for a great roasting software. regards, Philip Lundberg, Sweden)

MAKOMO commented 2 years ago

Philip, your settings look ok. Could you please send me your Artisan log file to check if I can read there what is going on here? Just click the plus icon in the left top corner while holding the OPTION key pressed. This will open an email with those log files attached. Please send them to info@artisan.plus.

MAKOMO commented 1 year ago

The issue could be duplicated and is related to the optimizer in the MODBUS and S7 module in Artisan not covering "external" reads as required to send keep-alive pings on controlling Probat/K&M machines. Commit 6e92f28880b33796cf1b027c46f9d7e5ae7a953c fixes this.