search

artiso-solutions / CoVoX

MIT License
1 stars 1 forks source link

Read Azure configuration from env variables #43

Closed tommasobertoni closed 3 years ago

tommasobertoni commented 3 years ago

Provide additional settings API to read the azure keys from environment variables. like:

COVOX__AZURE__SUBSCRIPTIONKEY
COVOX__AZURE__REGION

or

COVOX__AZURE__CONFIG (subscriptionKey:region)
antonio8101 commented 3 years ago

I think that it could be better to have 2 env variables not one that should be splitted used magic words.. That's to make simpler the troubleshooting when something it's not correct.. I would suggest to have two key env COVOX_AZURE_SUBSCRIPTION, COVOX_AZURE_REGION (the first of the 2 proposals @tommasobertoni wrote) cc @kczornik

kczornik commented 3 years ago

I pushed the changes to the proposals/ensure-valid-configuration branch. Changed can be merged in #51