artistro08 / tailor-starter

A builder theme for October CMS v3.2 - v3.3 based on Bootstrap 5 to speed up website creation
https://octobercms.com/theme/artistro08-tailorstartertheme
24 stars 5 forks source link

Blueprint Conflict for Blog/Post #66

Closed chrisvidal closed 1 year ago

chrisvidal commented 1 year ago

I think there is a conflict happening with this blueprint Blog/Post when the demo theme has been installed, used, and migrated. Which ends up as there is no Blog menu at all anywhere.

artistro08 commented 1 year ago

Should be fixed in v6.2.4

This also means that you may lose all your posts from the Blog\Posts entry type. I had to change the uuid for this to be fixed.

You also may be able to export and import the posts as well

chrisvidal commented 1 year ago

Still no Blog menu after updating to v6.2.5 and re-seeding everything

artistro08 commented 1 year ago

Hmm, I'll investigate more. In the meantime, try changing the primaryNavigation handle to see if that helps

artistro08 commented 1 year ago

Looks like it was a plugin issue. It's fixed in v1.0.17.

Since the plugin looks for all menu items that contain the text "Blog" when disabled, it hides the demo one as well. Update the plugin and let me know if that fix helps.

chrisvidal commented 1 year ago

got it , makes sense. Let me try to update and check

chrisvidal commented 1 year ago

It's fixed in v1.0.17.

this plugin version is not yet published, right? Cant get it to update to 1.0.17 with the PHP artisan command

artistro08 commented 1 year ago

That's really weird. It's up on the tags now and on the marketplace. Since the plugin name has changed, I'd check to see if the github version is updating.

chrisvidal commented 1 year ago

the command line is not updating the plugin and the backend system updates settings menu can see the new version but it can't update. not sure why. I did try a new install from scratch with the plugin, and I got the 1.0.16 installed, not the 1.0.17

artistro08 commented 1 year ago

Sounds like a composer issue. What's in your composer.json file? Send it to me directly

chrisvidal commented 1 year ago

for the new fresh install, composer.json is

{
    "name": "october/october",
    "description": "Built using October CMS: The Laravel-Based CMS Engineered For Simplicity",
    "type": "project",
    "homepage": "https://octobercms.com",
    "license": "proprietary",
    "require": {
        "php": "^8.0.2",
        "october/rain": "^3.2",
        "laravel/framework": "^9.0",
        "october/all": "^3.1",
        "artistro08/tailorstartercompanion-plugin": "^1.0",
        "artistro08/tailorstartertheme-theme": "^6.2"
    },
    "require-dev": {
        "phpunit/phpunit": "^8.5|^9.0"
    },
    "scripts": {
        "post-root-package-install": [
            "@php -r \"file_exists('.env') || copy('.env.example', '.env');\""
        ],
        "post-create-project-cmd": [
            "php artisan key:generate --ansi"
        ],
        "post-autoload-dump": [
            "System\\Console\\ComposerScript::postAutoloadDump"
        ],
        "post-update-cmd": [
            "System\\Console\\ComposerScript::postUpdateCmd"
        ],
        "pre-package-uninstall": [
            "System\\Console\\ComposerScript::prePackageUninstall"
        ],
        "test": [
            "phpunit --stop-on-failure"
        ]
    },
    "config": {
        "preferred-install": "dist",
        "allow-plugins": {
            "composer/installers": true
        }
    },
    "autoload": {
        "psr-4": {
            "System\\Console\\": "modules/system/console"
        }
    },
    "minimum-stability": "dev",
    "prefer-stable": true,
    "repositories": {
        "octobercms": {
            "type": "composer",
            "url": "https://gateway.octobercms.com",
            "only": [
                "october/*",
                "*-plugin",
                "*-theme"
            ]
        }
    }
}
artistro08 commented 1 year ago

Your composer file looks good. Try running just:

composer update
chrisvidal commented 1 year ago

interesting, after the composer update result:

composer update
Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Lock file operations: 0 installs, 4 updates, 0 removals
  - Upgrading artistro08/tailorstartercompanion-plugin (v1.0.16 => v1.0.18)
  - Upgrading artistro08/tailorstartertheme-theme (v6.2.5 => v6.3.0)
  - Upgrading composer/composer (2.5.3 => 2.5.4)
  - Upgrading league/commonmark (2.3.8 => 2.3.9)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 4 updates, 0 removals
  - Downloading artistro08/tailorstartercompanion-plugin (v1.0.18)
  - Downloading artistro08/tailorstartertheme-theme (v6.3.0)
  - Downloading league/commonmark (2.3.9)
  - Downloading composer/composer (2.5.4)
  - Upgrading artistro08/tailorstartercompanion-plugin (v1.0.16 => v1.0.18): Extracting archive
  - Upgrading artistro08/tailorstartertheme-theme (v6.2.5 => v6.3.0): Extracting archive
  - Upgrading league/commonmark (2.3.8 => 2.3.9): Extracting archive
  - Upgrading composer/composer (2.5.3 => 2.5.4): Extracting archive
Generating autoload files
> System\Console\ComposerScript::postAutoloadDump

   INFO  Discovering packages.  

  laravel/tinker ..................................................................... DONE
  nesbot/carbon ...................................................................... DONE
  nunomaduro/termwind ................................................................ DONE
  october/rain ....................................................................... DONE

95 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
> System\Console\ComposerScript::postUpdateCmd

* You are using October CMS version: v3.2.13

but the plugin is still in version 1.0.16 after update in the backend

image

and checking the version.yaml of the plugin, it looks properly updated

image

it looks like an issue with the OC platform then

chrisvidal commented 1 year ago

After this update, the homepage works again, without me doing anything than navigating to the homepage

artistro08 commented 1 year ago

try running php artisan october:migrate as well, it should update the version after that too.

and glad that it's working again!