Rename the package to laser_odometry_plugin_rf2o

artivis / laser_odometry_rf2o

A laser_odometry wrapper for rf2o.

https://github.com/artivis/laser_odometry

2 stars 2 forks source link

Open jvgomez opened 6 years ago

jvgomez commented 6 years ago

The current name is very confusing with the upstream library: https://github.com/MAPIRlab/rf2o_laser_odometry

I suggest that you rename the plugin packages adding the plugin suffix to make it more clear.

artivis commented 6 years ago

Indeed it might be a little confusing however all existing plugins (laser_odometry_polar, laser_odometry_libpointmatcher, laser_odometry_csm) already follow this scheme. Also I find the suffix a little verbose...
Moreover, please notice that this plugin works with my fork of rf2o_laser_odometry since https://github.com/MAPIRlab/rf2o_laser_odometry/pull/6 and https://github.com/MAPIRlab/rf2o_laser_odometry/pull/10 are not merged upstream.