artivis / manif

A small C++11 header-only library for Lie theory.
https://artivis.github.io/manif
MIT License
1.51k stars 246 forks source link

Typo(?) for Jacobian of o-minus in the cheat sheet #285

Closed blue-ringed-octopus closed 8 months ago

blue-ringed-octopus commented 8 months ago

the jacobian shows $J^{\mathcal{\gamma}\ominus\mathcal{\chi}}_{\tau} = J_r^{-1}(\tau)$

is it supposed to mean $J^{\mathcal{\gamma}\ominus\mathcal{\chi}}_{\mathcal{\gamma}} = J_r^{-1}(\tau)$ ?

I assume $\tau = \mathcal{\gamma} \ominus \mathcal{\chi}$

joansola commented 8 months ago
imagen

directly from the paper.

Where did you find the formula that you posted?

blue-ringed-octopus commented 8 months ago

thank you for the reply, i found it on here https://github.com/artivis/manif/blob/devel/paper/Lie_theory_cheat_sheet.pdf

the right jacobian of right- $\ominus $

joansola commented 8 months ago

Nice catch! We'll fix it, thank you!

joansola commented 8 months ago

@artivis would you take care of this fix? I am not sure if I have access to the latex sources

joansola commented 8 months ago

@artivis I did change the latex sources in overleaf. However the version there and the one on github are quite different. So I did not push the changes here. I let you do it.

FYI: In the sources, I re-defined \bfMx and \bfMy to produce \mathcal{X} and \mathcal{Y} respectively, as in the paper.

artivis commented 8 months ago

Thanks for the ping.

I'll update the pdf asap :+1:.