search

artivis / rpipress-downloader

Download Raspberry Pi Press issues
MIT License
18 stars 5 forks source link

'You are up to date' Never prints #16

Open tripplehelix opened 5 months ago

tripplehelix commented 5 months ago 
if not download and not download_error:
    print(
        colors.OK 
        + 'You are up to date.\n' 
        + colors.ENDC
    )

It is never printed for some reason, it's also printed at the end. It should print after each check only if the latest magazine is already downloaded, for example currently we get (using my latest PR, also tested with master):

Latest HackSpace issue is N°79
You may need to wait for the free download.

Latest HelloWorld issue is N°23
Latest MagPi issue is N°142
You may need to wait for the free download.

Latest MagPi book is 'Retro Gaming with Raspberry Pi 3rd edition'
You may need to wait for the free download.

Latest MagPi book is 'The Official Raspberry Pi Handbook 2024'
You may need to wait for the free download.

Your favorite magazines are waiting for you in file:///home/tom/Magazines/

We should get:

Latest HackSpace issue is N°79
You may need to wait for the free download.

Latest HelloWorld issue is N°23
You are up to date.

Latest MagPi issue is N°142
You may need to wait for the free download.

Latest MagPi book is 'Retro Gaming with Raspberry Pi 3rd edition'
You may need to wait for the free download.

Latest MagPi book is 'The Official Raspberry Pi Handbook 2024'
You may need to wait for the free download.

Your favorite magazines are waiting for you in file:///home/tom/Magazines/
tripplehelix commented 5 months ago

I can't seem to figure this one out, especially when downloading the backlog.

They only offer the three most recent mags now, so making the -a flag default is probably worth it.

tripplehelix commented 5 months ago

This is now fixed with my PR.

tripplehelix commented 4 months ago

image

The last magazine MagPi never printed the You are up to date message.