Closed GoogleCodeExporter closed 9 years ago
Original comment by yan...@google.com
on 26 Jul 2012 at 2:42
A couple of things I figured out:
1. We should also change the Java package names to be based on
"com.google.api.client.extensions.android" instead of
"com.google.api.client.extensions.android2" or
"com.google.api.client.extensions.android3". That means deprecating the
existing packages with a reference to switch to the new simpler package naming.
2. In case the developer chooses to build against an older version of the
Android SDK, they would get Proguard warnings (i.e. which cause ProGaurd to
fail to work) about use of Java code that is not found. We should follow the
example of the Android support library. See the snippet from their
proguard.cfg:
# The support library contains references to newer platform versions.
# Don't warn about those in case this app is linking against an older
# platform version. We know about them, and they are safe.
-dontwarn android.support.**
3. We should literally include in the zip file bundle the proguard.cfg file to
use that includes this snippet. Maybe call it proguard-google-http-client.txt.
This follows the naming of the proguard-android.txt that is included with
Android SDK.
Original comment by yan...@google.com
on 1 Aug 2012 at 8:16
One more thought:
4. We should add a runtime check for the Android SDK build with a friendly
message. Make a reusable method like AndroidUtils.checkMinimumSdkLevel(int
minimumSdkLevel) that can be called safely. Otherwise, developers will just
see problems like ClassNotFoundError.
Original comment by yan...@google.com
on 1 Aug 2012 at 8:55
http://codereview.appspot.com/6447084/
Original comment by yan...@google.com
on 2 Aug 2012 at 9:01
Original comment by yan...@google.com
on 17 Aug 2012 at 11:03
Original issue reported on code.google.com by
yan...@google.com
on 22 Jun 2012 at 12:31