Imrpoved security and validation on creating address

artkonekt / appshell

AppShell is an Laravel Application boilerplate with UI, ACL, Users & Customers

https://konekt.dev/appshell

MIT License

80 stars 10 forks source link

Imrpoved security and validation on creating address #26

Closed S-DICKSON closed 3 years ago

S-DICKSON commented 3 years ago

Please go through this checklist, it is mandatory to accept your PR

[x] Include the summary of your change.
[ ] Make sure all the tests are passing
[ ] Make sure StyleCI is passing
[ ] In case you add new functionality, it must be covered by tests

I've changed the behaviour of get all attributes to get all attributes that are validated. It will force developers to use validated input when using input from the request.

https://laravel.com/docs/6.x/validation#creating-form-requests

S-DICKSON commented 3 years ago

First time making a PR request. So I will try to learn how to resolve the remaining checklist.

fulopattila122 commented 3 years ago

Hi and thanks for the PR.

These changes can (and need to) be done in your application, because the form requests are designed to be customizable: https://konekt.dev/concord/1.9/request-types#customizing-requests

Therefore there's no need to change this in the library (and change for every other application built on top of AppShell). Please apply the same changes directly in your application as described here: https://konekt.dev/concord/1.9/request-types#customizing-requests

Ps.: Correct me if I'm wrong and I'm missing something

S-DICKSON commented 3 years ago

@fulopattila122 Thanks for the feedback.