search

artkonekt / appshell

AppShell is an Laravel Application boilerplate with UI, ACL, Users & Customers
https://konekt.dev/appshell
MIT License
79 stars 10 forks source link

Swtiched default js to use javascript module #30

Closed peterson-umoke closed 2 years ago

peterson-umoke commented 2 years ago

fixed error for cannot use import statement outside a module, error occurs when trying to compile with inertiajs and laravel vite

fulopattila122 commented 2 years ago

How is this backward compatible for default use cases when there are no inertiajs and/or laravel vite?

I'm asking because if it's a one-off requirement in your app, you can achieve it locally by using Laravel's vendor blade overriding mechanism:

Simply create the resources/views/vendor/appshell/layouts/default/_js.blade.php file in your app and override it with your content.

peterson-umoke commented 2 years ago

You have valid point, i will close this pull request then. i have changes to recommend specific to laravel vite and if you be so kind, i will love to aid with documentation as well.

fulopattila122 commented 2 years ago

I have changes to recommend specific to laravel vite and if you be so kind, i will love to aid with documentation as well.

That would be great, we haven't had the bandwidth yet to complete the vite part. (So far, we're happy with the existing webpack tooling)