artnas / Unity-Plane-Mesh-Splitter

Split large meshes in Unity into smaller submeshes
MIT License
263 stars 41 forks source link

Splitting meshes with a larger grid size #6

Closed cbanwell closed 2 years ago

cbanwell commented 3 years ago

Just having a play with the asset, we have extremly large meshes 2-5kmsq, having a play with the grid size I edited the code to enable grid sizes > 256 to be used, but what I find is that the slit then seems to miss chunks out, just wondering if the original 64 grid size limit is a known limitation and if so what the reason is?

Btw. seems to work fine if grid size is less than 64.

artnas commented 3 years ago

The 64 grid size limit is just an arbitrary number - it should work well with higher values. Perhaps its some sort of a float rounding error?

artnas commented 3 years ago

Just having a play with the asset, we have extremly large meshes 2-5kmsq, having a play with the grid size I edited the code to enable grid sizes > 256 to be used, but what I find is that the slit then seems to miss chunks out, just wondering if the original 64 grid size limit is a known limitation and if so what the reason is?

Btw. seems to work fine if grid size is less than 64.

Hey I've recently picked up this project again and did you ever fix the error? If you have a mesh which is causing issues then feel free to email it to me or attach it here - I'll try and see what's going on.

cbanwell commented 3 years ago

Sure, I can’t upload one for all to see, anyway to get it to you privately, my email is: @.***(dot)co(dot)uk

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: Artur @.> Sent: 30 August 2021 16:01 To: @.> Cc: Christopher @.>; @.> Subject: Re: [artnas/Unity-Plane-Mesh-Splitter] Splitting meshes with a larger grid size (#6)

Just having a play with the asset, we have extremly large meshes 2-5kmsq, having a play with the grid size I edited the code to enable grid sizes > 256 to be used, but what I find is that the slit then seems to miss chunks out, just wondering if the original 64 grid size limit is a known limitation and if so what the reason is?

Btw. seems to work fine if grid size is less than 64.

Hey I've recently picked up this project again and did you ever fix the error? If you have a mesh which is causing issues then feel free to email it to me or attach it here - I'll try and see what's going on.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fartnas%2FUnity-Plane-Mesh-Splitter%2Fissues%2F6%23issuecomment-908416126&data=04%7C01%7C%7C0a9d673b48e74633aad008d96bc6fecb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637659324678514363%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=i5csu%2FUIXH7%2BS5w2kpWs8XTtp%2Fv6hcTxMe6UncC0ImY%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKNTSZYIA7S5FSYSR2UA5GDT7OMLFANCNFSM47HRPX5A&data=04%7C01%7C%7C0a9d673b48e74633aad008d96bc6fecb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637659324678524319%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=E5RPeTe%2BuykLHZgTyHr0VfWimwxjLLwgdSwz3AUMspU%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C0a9d673b48e74633aad008d96bc6fecb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637659324678524319%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=SoB1uaQHr5szB%2BY%2Bq%2FbCzlaxkQVPppwKlO9ACNd4Vfs%3D&reserved=0 or Androidhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C0a9d673b48e74633aad008d96bc6fecb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637659324678534274%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=FiLNBopRwXfVbsRWYsYeJAYy0AjScYNaxHngRjPH%2B5I%3D&reserved=0.

artnas commented 3 years ago

Sure, I can’t upload one for all to see, anyway to get it to you privately, my email is: @.***(dot)co(dot)uk

I think github has hidden the email - you can see my email on my profile on github

cbanwell commented 3 years ago

yep lol, thanks for investigating this in advance.

Just sent you a wetransfer