search

artoale / karma-brackets

Run spectacular karma test inside brackets
46 stars 5 forks source link

Great extension to brackets #12

Open johnhidey opened 10 years ago

johnhidey commented 10 years ago

@artoale Just wanted to say great extension to brackets. Works like a champ.

I do have one question though and that is that if I have karma-cli installed globally, why do you need the full path to karma. Would love to just say karma in your karma settings dialog in brackets. This took me a bit to figure out and was thinking it should be easier than that if karma-cli is install globally.

Great job otherwise.

artoale commented 10 years ago

Hi John! Thank you very much, very appreciated. I agree with you, it would be much easier to just use "karma" but unfortunately brackets node process runs without all the "env" variable you usually have in your terminal, including the $PATH variable (which tells where to find binaries, including karma). That's why I'm not able to provide an easier way to configure it :( Again, thank you very much for your feedback and don't hesitate to write me again if you have any question

Cheers Alessandro On Jul 17, 2014 2:01 AM, "John Hidey" notifications@github.com wrote:

@artoale https://github.com/artoale Just wanted to say great extension to brackets. Works like a champ.

I do have one question though and that is that if I have karma-cli installed globally, why do you need the full path to karma. Would love to just say karma in your karma settings dialog in brackets. This took me a bit to figure out and was thinking it should be easier than that if karma-cli is install globally.

Great job otherwise.

— Reply to this email directly or view it on GitHub https://github.com/artoale/karma-brackets/issues/12.

johnhidey commented 10 years ago

Take a look at brackets shell. I use child_process in there and I have access to all the environment variables. When you run the shell, in the prompt, just type in node --version or better yet, type in karma start karma.conf.js and you SHOULD :8ball: see that the command executes without issue. Just a thought. I have another issue I'm going to submit to you. Again, great job.

artoale commented 10 years ago

Uhm.. They might have changed the implementation recently then.... Good to know, will update soon :) On Jul 17, 2014 2:38 AM, "John Hidey" notifications@github.com wrote:

Take a look at brackets shell. I use child_process in there and I have access to all the environment variables. When you run the shell, in the prompt, just type in node --version or better yet, type in karma start karma.conf.js and you SHOULD [image: :8ball:] see that the command executes without issue. Just a thought. I have another issue I'm going to submit to you. Again, great job.

— Reply to this email directly or view it on GitHub https://github.com/artoale/karma-brackets/issues/12#issuecomment-49249614 .