search

artofscience / SAOR

Sequential Approximate Optimization Repository
GNU General Public License v3.0
5 stars 1 forks source link

Define the shape of `y` #29

Closed Giannis1993 closed 3 years ago

Giannis1993 commented 3 years ago

I was reading through intervening.py and realised that y does not have the same shape for Reciprocal and ConLin. Is that intentional? Imo it makes sense to force y to have a consistent shape in order to be able to use the same methods (e.g. _set_P, g_approx, dg_approx, ddg_approx, zo_term, etc.) regardless of the intereving variables chosen.

image

artofscience commented 3 years ago

total system is (n, m+1). This is split up in 1...i variable groups and 1....j response groups. Thus the size of y is (n_i, m_j) or (m_j, n_i), that is the number of variables and responses in the group.

artofscience commented 3 years ago

@Giannis1993 can we close this issue?