artofscience / SAOR

Sequential Approximate Optimization Repository
GNU General Public License v3.0
5 stars 1 forks source link

Refactoring ipopt solver #46

Closed MaxvdKolk closed 3 years ago

MaxvdKolk commented 3 years ago

@artofscience Could you take a look at the proposed changes?

Unfortunately not much progress on reducing the overlap between the IP solver variants. However, I did reoder the code a little:

I have not (yet) checked if this might have implications for performance though, but I will still try to do that. The tests still seem to pass, so I assume everything is still working as intended, but we might want to double check before merging this request.

artofscience commented 3 years ago

@MaxvdKolk can we merge this?