search

artofscience / SAOR

Sequential Approximate Optimization Repository
GNU General Public License v3.0
5 stars 1 forks source link

Bounds of problem and subproblem should be the same type #87

Closed artofscience closed 2 years ago

artofscience commented 2 years ago

Currently a problem consists of

  1. n, m
  2. xmin, xmax
  3. x0

A subproblem in addition consists of

  1. approx
  2. lims
  3. alpha, beta

The fact that a problem only consists of xmin, xmax, whereas a subproblem consists also of alpha, beta is imo confusing

A solver accepts any type of "problem", meaning both "problem or subproblem" and should be able to solve. Currently when providing a problem, the access to alpha and beta might be absend.

How to solve?

Imo switching the names alpha and beta to xmin and xmax would be a good option

MaxvdKolk commented 2 years ago

Yeah, moving all to xmin and xmax would makes sense I think.

Giannis1993 commented 2 years ago

Since there is a PR for that, I think we can close this issue.