search

artofscience / SAOR

Sequential Approximate Optimization Repository
GNU General Public License v3.0
5 stars 1 forks source link

Interface with `cvxopt` #89

Closed Giannis1993 closed 2 years ago

Giannis1993 commented 2 years ago

I'm sure we can improve the code, but it seems to be working. Need to write some tests as well, but first let's discuss a bit. Relative links can be found below: https://cvxopt.org/userguide/solvers.html#s-cp https://github.com/artofscience/SAOR/blob/886a2a34ca072992f91e33217d3df9f59473353a/sao/solvers/cvxopt_wrapper.py

artofscience commented 2 years ago

@Giannis1993 why does it not pass the tests? Looking forward to a comparison of speed between solvers for a TO problem.

Giannis1993 commented 2 years ago

@Giannis1993 why does it not pass the tests? Looking forward to a comparison of speed between solvers for a TO problem.

I had to add cvxopt to pytest.yml as a dependency.

MaxvdKolk commented 2 years ago

Looks good :+1: Minor remark regarding the class name, maybe just use CVXOPT?