search

artofthesmart / hypertext

An incredibly fast, compatible, and efficient Grav CMS theme.
http://hypertext.artofthesmart.com
MIT License
50 stars 13 forks source link

Make hypertext compatible with the Language Selector Plugin #67

Open handmeatowel opened 2 years ago

handmeatowel commented 2 years ago

Make hypertext compatible with the Language Selector Plugin (text-only).

artofthesmart commented 2 years ago

Hmm; this is a bit more work than I have time for right now. I'm 99% certain I would only implement the text version of the plugin, no dropdowns or flag images or anything. Then I'd need to learn how Grav handles languages to make sure they're linked properly in the resultant links.

I'm going to cut a new release to get the new header image functionality out there and put this on the back burner. If a few more people upvote this I'll come around for another look.

handmeatowel commented 2 years ago

Regarding the drop downs with hypertext I'd agree. If someone wanted to use hypertext with a drop down, it would be up to them to make the necessary changes to the theme as this would be counterproductive of the goals of hypertext. Could be done with some additional CSS perhaps.

Objectively speaking flag images for language selection don't make a lot of sense (they would for selecting a country, though). So I'd say you got that right as well :-)

Regarding theme work (which I'm unfortunately not capable of), perhaps this helps: https://discourse.getgrav.org/t/where-to-add-language-selector-code/17437 https://learn.getgrav.org/16/content/multi-language