search

arton / rjb

Ruby Java Bridge
https://www.artonx.org/collabo/backyard/?RubyJavaBridge
GNU Lesser General Public License v2.1
117 stars 34 forks source link

Use "javac -h" over "javah" as the latter is deprecated in Java 10. #63

Closed lamby closed 3 years ago

lamby commented 6 years ago 
The javah tool was deprecated as of JDK 9 [0] and has been removed in in JDK
10.

This was originally filed in Debian as #897664.

  [0] https://docs.oracle.com/javase/9/tools/javah.htm#JSWOR687
  [1] https://bugs.debian.org/897664
arton commented 6 years ago

Thank you for your PR. I'm not certain that := is an acceptable operator of nmake.exe (Visual C++ is the one of RJB's main target platform). I will test it asap.

lamby commented 6 years ago

I'm not certain that := is an acceptable operator of nmake.exe

Ah, interesting :)

lamby commented 6 years ago

@arton

I will test it asap.

Any update on this?

907th commented 5 years ago

@arton Why do not this PR is merged yet? I can not install rjb using openjdk 1.11 because of error make: javah: Command not found.

akiotajima commented 5 years ago

Hi 907th I don't know how to rewrite the line JAVAH := .... I can't merge this PR because namke.exe can not handle 'JAVAH := $(shell command -v javah 2>/dev/null)' with error code U1033. If you could solve the error, I will merge it.

akiotajima commented 5 years ago

I think you, Unix only person, should define this line in your .profile.

alias javah='javac -h'

arton commented 5 years ago

Above two comments were entered by me. I forgot to re-sign in with my 'arton' account.

lamby commented 5 years ago

GIven that this is called from (automated) build systems and generic Linux distributions, it's not really possible to set alias javah everywhere...

arton commented 5 years ago

Thanks lamby. I change the extconf.rb and use erb for modifying depend. Your PR is very helpful because I don't know the changed command line arguments of javac -h.

I wonder if you could accept the patch and close this PR. https://github.com/arton/rjb/issues/66

arton commented 3 years ago

@lamby Thank you for your PR.

I reconfigured your patch as using extconf.rb d08359d 9c35e85 13e4937