Contract Scaffolding - Githubissues

artonomous / artonomous-mvp

A Self-Owning, Self-Sustaining, Self-Improving Autonomous Artist Using the Ethereum Blockchain

158 stars 21 forks source link

Contract Scaffolding #15

Closed nickreynolds closed 6 years ago

nickreynolds commented 6 years ago

Creating some basic artonomous contracts to build out contract scaffolding.
Adding migrations.
Adding unit test framework and a few tests
Nothing in the contracts implementation is "for real", just thought it'd be a good idea to get these started so we can start iterating.

tarrencev commented 6 years ago

Minor feedback, otherwise looks good to me!

simondlr commented 6 years ago

I'm taking this week off for some personal time, so can't get to review. But since is just a scaffold more than anything else, I'm good to merge it so we can build on it. If there's not reason not to, let me know, otherwise I can merge later. :)

tarrencev commented 6 years ago

In that case I'd say go ahead! Enjoy your time off! 😎

nickreynolds commented 6 years ago

Yeah I think we should merge this in. No need for it to be perfect right now.

simondlr commented 6 years ago

Thanks for the contributions. Taking a look at this now.

Only change at this early stage that's necessary is that it should be blockhash (per 0.4.24) vs block.number as the input hash for the art piece.