artonomous / artonomous-mvp

A Self-Owning, Self-Sustaining, Self-Improving Autonomous Artist Using the Ethereum Blockchain
158 stars 21 forks source link

Drizzle Integration #28

Closed nickreynolds closed 6 years ago

nickreynolds commented 6 years ago
simondlr commented 6 years ago

Awesome. I've been meaning to give Drizzle a spin too. I want to play with this tomorrow a bit!

@tarrencev what do you think of moving back to truffle default vs a monorepo. Playing with monorepos is also on my to-do list, so not 100% sure on advantages/disadvantages.

I'll leave this repo open for now @nickreynolds if that's fine. Give it a day or two. :)

tarrencev commented 6 years ago

Just getting to this now, sorry for the delay was on vacation.

It seems this is still a monorepo, since we still have a separate package for the frontend. Which I think makes things easier to maintain.

This switches from using the "create-react-app" boilerplate to "drizzle-box", which is an extension of "create-react-app". I've played around with Drizzle a bit in the past and it provides a decent abstraction. I ended up migrating off of it, mostly because it didn't support multiple contract instances (which might have changed) but also since I prefer the more canonical redux pattern of action dispatching.

Overall I think this is fine, keeps us moving in the right direction 👍

simondlr commented 6 years ago

Cool. Merging for now. :)

simondlr commented 6 years ago

Also. Welcome back @tarrencev! Hope the holiday was fun.

tarrencev commented 6 years ago

Thanks @simondlr :)